Search Linux Wireless

Re: [PATCH v2 3/3] mt76: mt7615: add set_coverage class support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes:

>> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes:
>> 
>> > Add the capability to configure actimeout for mt7615 driver. Moreover
>> 
>> acktimeout?
>
> Hi Kalle,
>
> yes, it suppposed to be acktimeout
>
>> 
>> > configure slottime according to the value provided by mac80211
>> >
>> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
>> 
>> [...]
>> 
>> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
>> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
>> > @@ -60,6 +60,47 @@ void mt7615_mac_reset_counters(struct mt7615_dev *dev)
>> >  	mt76_set(dev, MT_WF_RMAC_MIB_AIRTIME0, MT_WF_RMAC_MIB_RXTIME_CLR);
>> >  }
>> >  
>> > +/* XXX: DBDC support */
>> > +void mt7615_mac_set_timing(struct mt7615_dev *dev)
>> 
>> Should this be "FIXME:"? Thought don't remember what style is used in
>> mt76.
>
> actually for DBDC we used TODO.

Even better.

> Should I resend?

No strong feelings from me, just wanted to point out while reviewing the
pathces. Up to Felix :)

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux