On 2019-11-20 12:42, Lorenzo Bianconi wrote: >> On 2019-11-15 16:05, Lorenzo Bianconi wrote: >> > Move coverage_class and slottime fields from driver specific data >> > structure to mt76_dev since they are used by all drivers >> > >> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> >> Please drop this patch. I've moved a few other fields back from struct >> mt76_dev to driver specific structs, because they were in the way of >> DBDC related rework, and this one would fit the category too. >> >> As a general policy, I think we should only move fields to struct >> mt76_dev if they are actually used by core code as well. > > ack, let's drop this patch. In the future we will need to integrate the timeing > code in DBDC one since mt7615 has related regs for band0 and band1. Maybe we need > to move them in mt76_phy?I'd prefer struct mt7615_phy for now, unless we have a good reason to keep it in mt76 core. - Felix
