On Thu, Aug 7, 2008 at 8:21 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > It is obviously good for userspace to know up front which interface modes > a given piece of hardware might support (even if adding such an interface > might fail later because of concurrency issues), so let's make cfg80211 > aware of that. For good measure, disallow adding interfaces in all other > modes so drivers don't forget to announce support for one mode when they > add it. > > This patch is incomplete as it doesn't modify all drivers. The driver > modifications should be straight-forward, I'm hoping somebody else > can pick it up and collect the necessary driver changes. Included is a > b43 change because I tested it with that. I have also pushed an iw > change to print out this information. > > It's a bit ugly that it requires drivers to use nl80211 constants, but > if anything mac80211 should migrate to using those completely instead > of translating them to its own versions. This is nice :) > --- everything.orig/drivers/net/wireless/b43/main.c 2008-08-07 16:49:57.000000000 +0200 > +++ everything/drivers/net/wireless/b43/main.c 2008-08-07 16:57:12.000000000 +0200 > @@ -4165,11 +4165,11 @@ static int b43_op_add_interface(struct i > > /* TODO: allow WDS/AP devices to coexist */ > > - if (conf->type != IEEE80211_IF_TYPE_AP && > - conf->type != IEEE80211_IF_TYPE_MESH_POINT && > - conf->type != IEEE80211_IF_TYPE_STA && > - conf->type != IEEE80211_IF_TYPE_WDS && > - conf->type != IEEE80211_IF_TYPE_IBSS) > + if (WARN_ON(conf->type != IEEE80211_IF_TYPE_AP && When would we hit the WARN_ON() ? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
