Search Linux Wireless

Re: [PATCH v4 4/4] mt76: mt76x02: add channel switch support for usb interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/19/19 12:19 PM, Stanislaw Gruszka wrote:
> On Mon, Nov 18, 2019 at 11:15:40PM +0100, Markus Theil wrote:
>> +static void mt76x2u_channel_switch_beacon(struct ieee80211_hw *hw,
>> +					  struct ieee80211_vif *vif,
>> +					  struct cfg80211_chan_def *chandef)
>> +{
>> +}
>> +
>>  const struct ieee80211_ops mt76x2u_ops = {
>>  	.tx = mt76x02_tx,
>>  	.start = mt76x2u_start,
>> @@ -121,4 +127,5 @@ const struct ieee80211_ops mt76x2u_ops = {
>>  	.get_survey = mt76_get_survey,
>>  	.set_tim = mt76_set_tim,
>>  	.release_buffered_frames = mt76_release_buffered_frames,
>> +	.channel_switch_beacon = mt76x2u_channel_switch_beacon,
> Is this needed ? Seems mac80211 check against this op being NULL
> in drv_channel_switch_beacon() and it is not used otherwise.
>  
> Stanislaw
I checked if this call is really needed and you're right, it is not
needed. I'll send v5 with this fix.



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux