On Thu, Aug 7, 2008 at 9:33 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2008-08-07 at 01:42 +0300, Tomas Winkler wrote: >> On Wed, Aug 6, 2008 at 10:45 PM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > Otherwise, drivers are required to keep track of the sequence numbers >> > themselves, and they really shouldn't be since we already do it for >> > them. I'll fix the race once we figure out how this code should work >> > at all, it's currently disabled. >> > >> > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> >> >> Finally I know why nothing works in iwlwifi. This is most crucial >> point of correct driver behavior. >> There is direct mapping between hw queue indexes and sequence numbers.... >> This is bad. > > Eh, this particular patch has nothing to do with iwlwifi at all because > iwlwifi overrides all sequence numbers anyway. I'm not referring to this patch but to expected behavior that was broken. Second I'm not sure mac should keep track of sequence numbers. In theory driver can drop packets in processing and this may confuse sequence progress. I've already wrote about it... Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
