Hi Markus, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on wireless-drivers-next/master] [also build test WARNING on next-20191118] [cannot apply to v5.4-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Markus-Theil/mt76-channel-switch-support-for-USB-devices/20191118-215808 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=sparc64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/list.h:9:0, from include/linux/module.h:9, from drivers/net/wireless/mediatek/mt76/usb.c:6: drivers/net/wireless/mediatek/mt76/usb.c: In function 'mt76u_copy': include/linux/kernel.h:842:29: warning: comparison of distinct pointer types lacks a cast (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ include/linux/kernel.h:856:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^~~~~~~~~~~ include/linux/kernel.h:866:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~~~~~~~~~ include/linux/kernel.h:875:19: note: in expansion of macro '__careful_cmp' #define min(x, y) __careful_cmp(x, y, <) ^~~~~~~~~~~~~ >> drivers/net/wireless/mediatek/mt76/usb.c:159:24: note: in expansion of macro 'min' current_batch_size = min(sizeof(usb->data), len - i); ^~~ vim +/min +159 drivers/net/wireless/mediatek/mt76/usb.c 147 148 static void mt76u_copy(struct mt76_dev *dev, u32 offset, 149 const void *data, int len) 150 { 151 struct mt76_usb *usb = &dev->usb; 152 const u8 *val = data; 153 int ret; 154 int current_batch_size; 155 int i = 0; 156 157 mutex_lock(&usb->usb_ctrl_mtx); 158 while (i < len) { > 159 current_batch_size = min(sizeof(usb->data), len - i); 160 memcpy(usb->data, val + i, current_batch_size); 161 ret = __mt76u_vendor_request(dev, MT_VEND_MULTI_WRITE, 162 USB_DIR_OUT | USB_TYPE_VENDOR, 163 0, offset + i, usb->data, 164 current_batch_size); 165 if (ret < 0) 166 break; 167 168 i += current_batch_size; 169 } 170 mutex_unlock(&usb->usb_ctrl_mtx); 171 } 172 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip
