Thanks for your careful review, Kalle. I updated v3 with regards to your comments. Ming -----Original Message----- From: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Sent: Thursday, November 14, 2019 11:16 PM To: Ming Chen <ming032217@xxxxxxxxx> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; Ming Chen <Ming.Chen@xxxxxxxxxxxxxx> Subject: Re: [PATCH v2] mac80211: Drop the packets whose source or destination mac address is empty Ming Chen <ming032217@xxxxxxxxx> writes: > We occasionally found ath9k could receive some packets from Linux IP > stack with empty source and destination mac address,which will result > in the driver cannot find the station node in TX complete. And thus, > the driver will complete this buffer but without updating the block ack window. > > To fix this issue, we should drop this kind of error packet before it > goes into the driver. The s-o-b line should be here, before the "---" line. > --- > > According to review feedback, use the is_zero_ether_addr to check if > the mac address is empty. Very good that you added the changelog, but to make it more obvious you could, for example, mark the changelog like this: --- v3: Fix s-o-b location v2: According to review feedback, use the is_zero_ether_addr to check if the mac address is empty. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
