Thanks. > Could you please take a quick look at whether this looks like a correct > way of introducing new functionality into cfg80211? I'll finish the > short slot time part in mac80211 and post an updated patch as a proper > submission later. I used to have a patch to move the short-slot stuff in mac80211 to the BSS info struct so that drivers that support different slot timing for each frame can use it for different virtual BSSes. It no longer applies though: http://johannes.sipsolutions.net/patches/kernel/all/2008-08-04-12%3a26/013-BROKEN-mac80211-bss-slot-time.patch > +static int ieee80211_change_bss(struct wiphy *wiphy, > + struct net_device *dev, > + struct bss_parameters *params) > +{ > + struct ieee80211_local *local = wiphy_priv(wiphy); > + struct ieee80211_sub_if_data *sdata; > + > + if (dev == local->mdev) > + return -EOPNOTSUPP; > + > + sdata = IEEE80211_DEV_TO_SUB_IF(dev); I think you may need to handle the case where dev is a VLAN? Or do we want to have these settings per VLAN too? And should we reject them for other modes than AP where the AP controls the settings? > + * @NL80211_CMD_SET_BSS: Set BSS attributes for BSS identified by > + * %NL80211_ATTR_IFINDEX. Maybe we should have a way to retrieve the settings as well, and that could even work in STA mode to see what the AP asked us to do. Other than that, looks good to me. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
