Luca Coelho <luca@xxxxxxxxx> writes: > Here's the second batch of patches intended for v5.4. This includes the > last patchset 2 patchsets I sent. Usual development work. More > details about the contents in the tag description. > > I pushed these patches to my pending branch when I sent them out and > kbuildbot reported success. > > Please let me know if there are any issues. I did a test pull and it fails to build for me, error below. I had 'CONFIG_ACPI=y' in the config, in case that makes a difference. drivers/net/wireless/intel/iwlwifi/mvm/fw.c:683:15: warning: 'struct iwl_mvm_sar_profile' declared inside parameter list will not be visible outside of this definition or declaration struct iwl_mvm_sar_profile *profile, ^~~~~~~~~~~~~~~~~~~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_set_profile': drivers/net/wireless/intel/iwlwifi/mvm/fw.c:688:9: error: dereferencing pointer to incomplete type 'struct iwl_mvm_sar_profile' profile->enabled = enabled; ^~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_wrds_table': drivers/net/wireless/intel/iwlwifi/mvm/fw.c:732:48: error: 'struct iwl_mvm' has no member named 'sar_profiles' ret = iwl_mvm_sar_set_profile(mvm, table, &mvm->sar_profiles[0], ^~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_ewrd_table': drivers/net/wireless/intel/iwlwifi/mvm/fw.c:786:16: error: 'struct iwl_mvm' has no member named 'sar_profiles' &mvm->sar_profiles[i + 1], ^~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_wgds_table': drivers/net/wireless/intel/iwlwifi/mvm/fw.c:822:5: error: 'struct iwl_mvm' has no member named 'geo_rev' mvm->geo_rev = tbl_rev; ^~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c:834:7: error: 'struct iwl_mvm' has no member named 'geo_profiles' mvm->geo_profiles[i].values[j] = entry->integer.value; ^~ At top level: drivers/net/wireless/intel/iwlwifi/mvm/fw.c:800:12: warning: 'iwl_mvm_sar_get_wgds_table' defined but not used [-Wunused-function] static int iwl_mvm_sar_get_wgds_table(struct iwl_mvm *mvm) ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c:739:12: warning: 'iwl_mvm_sar_get_ewrd_table' defined but not used [-Wunused-function] static int iwl_mvm_sar_get_ewrd_table(struct iwl_mvm *mvm) ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/net/wireless/intel/iwlwifi/mvm/fw.c:701:12: warning: 'iwl_mvm_sar_get_wrds_table' defined but not used [-Wunused-function] static int iwl_mvm_sar_get_wrds_table(struct iwl_mvm *mvm) ^~~~~~~~~~~~~~~~~~~~~~~~~~ scripts/Makefile.build:265: recipe for target 'drivers/net/wireless/intel/iwlwifi/mvm/fw.o' failed -- Kalle Valo