> > - 'apply to all TIDs' usecase > > Currently, if peer is not specified, then configuration is applied to > > all the connected STAs. It is tempting to use some spare TID value > > to inform drivers that provided configuration should be applied to > > all TIDs of the specified STA or even to all TIDS and STAs. But that > > can not be left up to drivers since this value needs to be passed > > from userspace tools, e.g. from iw. > > I was *just* replying on exactly the same point over in patch 1 (not > sent yet). It's actually not even clear to me that the configuration > really would be applied to *all* STAs, it's sort of left open for the > driver, afaict? > > But I agree with you that this is not a good thing. > > I don't think using a spare TID value is the right signalling, we can > add another attribute? E.g. we could easily add > > NL80211_TID_CONFIG_ATTR_OVERRIDE > > and make that be > > @NL80211_TID_CONFIG_ATTR_OVERRIDE: flag attribute, valid only if no STA > is selected, if set indicates that the new configuration > overrides all previous STA configurations, otherwise previous > STA-specific configurations should be left untouched > > You also raise a good point wrt. "all TIDs" - but then we should > probably just remove NL80211_TID_CONFIG_ATTR_TID and add a new > NL80211_TID_CONFIG_ATTR_TIDS as a bitmap? OTOH, it's not hard to just > explicitly spell out all TIDs either, I guess, just makes the message a > bit bigger. The idea with bitmask for TIDs looks good. It eliminates the need for both 'all TIDs' define and additional attribute NL80211_TID_CONFIG_ATTR_OVERRIDE. In fact, almost no changes are needed for the patch, mostly comments need to be updated. Manual typing in iw will be less convenient, but I guess this interface is not supposed to be used by humans after all... Regards, Sergey
