On Tue, Nov 5, 2019 at 2:57 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > > Write the CC rule such that it only tries to produce a single output > file (the .so). When including the .h files in the compiler invocation, > this suggests we should be producing pre-compiled headers too, which > doesn't make sense in this context, and Clang happens not to like. > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> > --- Apparently wireless-regdb@ is subscribers only. I have since joined, but I guess my patch bounced from that list... if I don't hear back in a while, I may resend. Brian > Yes, I know CRDA is deprecated. > > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 6169b1f307da..6ca26f341dfa 100644 > --- a/Makefile > +++ b/Makefile > @@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem) > $(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem) > $(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@ > > -$(LIBREG): regdb.h reglib.h reglib.c > +$(LIBREG): reglib.c regdb.h reglib.h > $(NQ) ' CC ' $@ > - $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^ > + $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $< > > install-libreg-headers: > $(NQ) ' INSTALL libreg-headers' > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >
