On Tue, Nov 05, 2019 at 10:08:45AM +0100, Petr Štetiar wrote: > Stanislaw Gruszka <sgruszka@xxxxxxxxxx> [2019-11-05 10:00:44]: > > Hi, > > > I provided the topic in the first reference of the commit at the top. > > Should I do this anytime in the chenglog when a commit is referenced, > > even if it's done already ? > > ./scripts/checkpatch.pl 0001-Revert-mt76-mt76x0e-don-t-use-hw-encryption-for-MT76.patch > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")' > #8: > Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs") Okay, so I should add word 'commit' before HASH. > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")' > #14: > fixed by 7bd0650be63c , we can enable HW encryption back. It's not clear if topic is need, but I can change it on the way. BTW I hate checkpath.pl . Stanislaw