Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: > On Tue, Nov 05, 2019 at 10:21:13AM +0200, Kalle Valo wrote: >> Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: >> >> > This reverts commit 34b0e9b767bfa09ae233ca0d6ceb299bf2e24600. >> > >> > Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs") >> > is no longer necessary to disable HW encryption for MT7630E. >> > >> > Disabling HW encryption helped previously because somehow fragmented >> > skb's are not created if mac80211 encrypt frames, so buffer unmap bug >> > of non-linear skbs was not triggered. Now since this bug if properly >> > fixed by 7bd0650be63c , we can enable HW encryption back. >> >> This should be: >> >> ... fixed by commit 7bd0650be63c ("mt76: dma: fix buffer unmap with >> non-linear skbs"), we can enable ... > > I provided the topic in the first reference of the commit at the top. > Should I do this anytime in the chenglog when a commit is referenced, > even if it's done already ? Sorry, I missed that. Yes, you are right and ignore my comment. -- Kalle Valo