Search Linux Wireless

Re: [PATCH 3/3] b43legacy: ASoC: ux500: Remove redundant variable "count"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi zhong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[cannot apply to v5.4-rc5 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/zhong-jiang/ipw2x00-Remove-redundant-variable-rc/20191102-114138
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

   drivers/net/wireless/broadcom/b43legacy/debugfs.c: In function 'tsf_read_file':
>> drivers/net/wireless/broadcom/b43legacy/debugfs.c:56:17: error: 'count' undeclared (first use in this function); did you mean 'ucounts'?
      if (bufsize - count)    \
                    ^
>> drivers/net/wireless/broadcom/b43legacy/debugfs.c:71:2: note: in expansion of macro 'fappend'
     fappend("0x%08x%08x\n",
     ^~~~~~~
   drivers/net/wireless/broadcom/b43legacy/debugfs.c:56:17: note: each undeclared identifier is reported only once for each function it appears in
      if (bufsize - count)    \
                    ^
>> drivers/net/wireless/broadcom/b43legacy/debugfs.c:71:2: note: in expansion of macro 'fappend'
     fappend("0x%08x%08x\n",
     ^~~~~~~
   drivers/net/wireless/broadcom/b43legacy/debugfs.c: In function 'ucode_regs_read_file':
>> drivers/net/wireless/broadcom/b43legacy/debugfs.c:56:17: error: 'count' undeclared (first use in this function); did you mean 'ucounts'?
      if (bufsize - count)    \
                    ^
   drivers/net/wireless/broadcom/b43legacy/debugfs.c:96:3: note: in expansion of macro 'fappend'
      fappend("r%d = 0x%04x\n", i,
      ^~~~~~~
   drivers/net/wireless/broadcom/b43legacy/debugfs.c: In function 'txstat_read_file':
>> drivers/net/wireless/broadcom/b43legacy/debugfs.c:56:17: error: 'count' undeclared (first use in this function); did you mean 'ucounts'?
      if (bufsize - count)    \
                    ^
   drivers/net/wireless/broadcom/b43legacy/debugfs.c:132:3: note: in expansion of macro 'fappend'
      fappend("Nothing transmitted, yet\n");
      ^~~~~~~

vim +56 drivers/net/wireless/broadcom/b43legacy/debugfs.c

75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  52  
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  53  
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  54  #define fappend(fmt, x...)	\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  55  	do {							\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25 @56  		if (bufsize - count)				\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  57  			count += snprintf(buf + count,		\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  58  					  bufsize - count,	\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  59  					  fmt , ##x);		\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  60  		else						\
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  61  			printk(KERN_ERR "b43legacy: fappend overflow\n"); \
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  62  	} while (0)
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  63  
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  64  
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  65  /* wl->irq_lock is locked */
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  66  static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  67  {
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  68  	u64 tsf;
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  69  
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  70  	b43legacy_tsf_read(dev, &tsf);
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25 @71  	fappend("0x%08x%08x\n",
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  72  		(unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  73  		(unsigned int)(tsf & 0xFFFFFFFFULL));
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  74  
5a61f708c80868 drivers/net/wireless/broadcom/b43legacy/debugfs.c zhong jiang  2019-10-31  75  	return 0;
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  76  }
75388acd0cd827 drivers/net/wireless/b43legacy/debugfs.c          Larry Finger 2007-09-25  77  

:::::: The code at line 56 was first introduced by commit
:::::: 75388acd0cd827dc1498043daa7d1c760902cd67 [B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices

:::::: TO: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux