Luca Coelho <luca@xxxxxxxxx> writes: > From: Haim Dreyfuss <haim.dreyfuss@xxxxxxxxx> > > There are various of flows which require tids flushing > (disconnection, suspend, etc...). > Currently, when the driver instructs the FW to flush > he masks all the data tids(0-7). > However, the driver doesn't set the management tid (#15) > which cause the FW not to flush it. > When the FW tries to remove the mgmt queue he throws an assert > since it is not an empty queue. > instead of just set only the data tids set everything and let > the FW ignore the invalid tids. > > Signed-off-by: Haim Dreyfuss <haim.dreyfuss@xxxxxxxxx> > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx> [...] > - ret = iwl_mvm_flush_sta_tids(mvm, flush_arg, 0xFF, 0) ? : count; > + ret = iwl_mvm_flush_sta_tids(mvm, flush_arg, 0xFFFF, 0) [...] > - iwl_mvm_flush_sta_tids(mvm, i, 0xFF, 0); > + iwl_mvm_flush_sta_tids(mvm, i, 0xFFFF, 0); [...] > - 0xff | BIT(IWL_MGMT_TID), flags); > + 0xffff, flags); If, instead of magic values, you had a proper define this would be a simple change. Hint hint ;) No need to change anything, but something to keep in mind. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
