Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
>> +module_param_named(debug_mask, ath11k_debug_mask, uint, 0644);
>> +
>> +MODULE_PARM_DESC(debug_mask, "Debugging mask");
>> +
>> +static const struct ath11k_hw_params ath11k_hw_params = {
>> + .name = "ipq8074",
>
> indentation here seems a bit too much
I'll fix that. I'll also group the module parameter macros above next to
each other.
>> +MODULE_LICENSE("Dual BSD/GPL");
>
> All your files state "ISC", shouldn't that be reflected here?
AFAIK MODULE_LICENSE() macro does not support ISC. AFAIK this is what
all ISC wireless drivers have.
Related to this, we now changed the license in ath11k to
BSD-3-Clause-Clear.
--
Kalle Valo
