On 2019/10/9 21:05, Kalle Valo wrote: > "zhengbin (A)" <zhengbin13@xxxxxxxxxx> writes: > >> On 2019/10/9 20:58, Kalle Valo wrote: >>> zhengbin <zhengbin13@xxxxxxxxxx> writes: >>> >>>> Fixes gcc '-Wunused-but-set-variable' warning: >>>> >>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw: >>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: >>>> variable err set but not used [-Wunused-but-set-variable] >>>> >>>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> >>>> Signed-off-by: zhengbin <zhengbin13@xxxxxxxxxx> >>>> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> >>> There's no changelog, why did you resend? Document clearly the changes >>> so that maintainers don't need to guess what has changed: >> Failed to apply: >> >> fatal: corrupt patch at line 13 >> error: could not build fake ancestor >> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err' >> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err' >> The copy of the patch that failed is found in: .git/rebase-apply/patch >> >> So I resend this. > Ok, thanks. But next time include the changelog automatically and mark > the patch as v2. And read the documentation: Copy that, thank your for your patience > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >