Search Linux Wireless

Re: [PATCH] mac80211: fix use of skb->cb for mesh forwarding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  static ieee80211_rx_result debug_noinline
> +ieee80211_rx_h_mesh_fwding(struct ieee80211_rx_data *rx)
> +{


> @@ -1683,6 +1697,8 @@ static void ieee80211_invoke_rx_handlers(struct ieee80211_sub_if_data *sdata,
>  	/* must be after MMIC verify so header is counted in MPDU mic */
>  	CALL_RXH(ieee80211_rx_h_remove_qos_control)
>  	CALL_RXH(ieee80211_rx_h_amsdu)
> +	if (ieee80211_vif_is_mesh(&sdata->vif))
> +		CALL_RXH(ieee80211_rx_h_mesh_fwding);

CALL_RXH cannot be used like that, it's not a statement, you should
probably make it one or put the vif_is_mesh test into the
ieee80211_rx_h_mesh_fwding function instead.

> +#define skb_get_80211_fc(skb) (((struct ieee80211_hdr *) skb->data) \
> +				->frame_control)
> +	if (ieee80211_vif_is_mesh(&osdata->vif) &&

I'd rather just define the hdr struct you have two lines down before,
it'll just be optimised out when mesh isn't there.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux