Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Sun, 2019-10-06 at 19:40 +0200, Toke Høiland-Jørgensen wrote: > >> > That's a good point. I haven't thought about real simultaneous dual >> > band chipset and such chipset do exists now. Is RSDB support coming to >> > mac80211 soon? Just curious if it will be just virtual interfaces or >> > something else. I chose "local" instead of "sdata" thinking about the >> > case of several virtual interfaces (AP, STA, MESH) operates in the >> > same channel, then the interface total could be a better choice. >> > >> > I am ok with moving the "aql_total_pending_airtime" into sdata, but >> > afraid that's not the most optimal choice for the case of multiple >> > virtual interfaces operates in the same channel. >> > Maybe we could leave it in "local" for now. What do you think? >> >> I'd lean towards keeping it in 'local' for consistency with all the >> other airtime stuff. For now, I think having multiple SSIDs on the same >> radio is more common than the reverse (multiple bands on a single >> radio). >> >> In particular, the per-group airtime fairness stuff is definitely >> designed on the assumption that all BSSes share the same band. > > s/band/channel/, presumably. Indeed :) >> So if and when we start supporting true multi-band devices we'll have to >> change these things anyway. So might as well keep everything together so >> it all gets fixed :) > > I guess I'm OK with that, but I'm pretty sure this will come up sooner > rather than later ... > > What else is there though? By "it all" I meant "all the airtime fairness stuff". Other than that, I didn't have anything in particular in mind. I just kinda assumed there would be lots of places that had an implicit assumption that all devices on the same phy shares a channel... -Toke
