On 2019-09-24 00:49, Tom Psyborg wrote:
On 24/09/2019, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
Tomislav Požega <pozega.tomislav@xxxxxxxxx> writes:
Actually I prefer the original style, so that we first check the data
in
skb is valid and only then assign the data to ev.
--
Kalle Valo
It came to my mind that this might be the reason why the current
driver did not give me warning about too short service ready event,
but there was no warning about event length in either case.
I even tested this with compat wireless from 2013. and there the
situation was the opposite: in both cases there was warning about
service ready length.
Hmmm, my understanding of the way the TLV WMI is supposed to work is
that the individual data structures are extensible, and in the case
where a data structure is received with a "short" length the recipient
is supposed to zero-extend to the expected length, and then handle the
"zeroed" field(s) appropriately. This is supposed to hold for both
host=>firmware and firmware=>host. Since the wmi_service_ready_event has
been extended over time this behavior is necessary in the case of a host
built with the current format interfacing to a firmware built with an
earlier version of the format. I'm not sure why ath10k isn't supporting
this since the QTI "out of tree" driver (my area of focus) has that
support.
