Hi Kalle, Sorry, I failed to follow up on some of this. On Fri, Sep 20, 2019 at 12:32 AM Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > But I mixed up the flags. I meant that can we enable > NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR in ath10k? Does the firmware > releases which have WMI_SERVICE_NLO support > NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR as well? I'm looking at firmware which supports WMI_SERVICE_NLO and WMI_SERVICE_SPOOF_MAC_SUPPORT. This leads to support for NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR and NL80211_WOWLAN_TRIG_NET_DETECT (good!), but it also leads to NL80211_CMD_START_SCHED_SCAN support and *not* NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR, which is inconsistent (bad!). (I think a few times in here you noted the FEATURE_SCAN variant, when you probably meant FEATURE_SCHED_SCAN.) If I understand Wen correctly, he is working on dropping NL80211_CMD_START_SCHED_SCAN, which would fix the inconsistency. But I also noticed that ath10k does not support NL80211_FEATURE_ND_RANDOM_MAC_ADDR, which is again an inconsistency: we're going to lose randomization when in WoWLAN + NET_DETECT mode. I don't suspect we (Chrome OS) would ever enable this feature in that state. Regards, Brian
