Search Linux Wireless

Re: [PATCH v2] mac80211: keep BHs disabled while calling drv_tx_wake_queue()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 1 Oct 2019, Toke Høiland-Jørgensen wrote:

> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes:
> 
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > Drivers typically expect this, as it's the case for almost all cases
> > where this is called (i.e. from the TX path). Also, the code in mac80211
> > itself (if the driver calls ieee80211_tx_dequeue()) expects this as it
> > uses this_cpu_ptr() without additional protection.
> >
> > This should fix various reports of the problem:
> > https://bugzilla.kernel.org/show_bug.cgi?id=204127
> > https://lore.kernel.org/linux-wireless/CAN5HydrWb3o_FE6A1XDnP1E+xS66d5kiEuhHfiGKkLNQokx13Q@xxxxxxxxxxxxxx/
> > https://lore.kernel.org/lkml/nycvar.YFH.7.76.1909111238470.473@xxxxxxxxxxxxx/
> >
> > Reported-by: Jiri Kosina <jikos@xxxxxxxxxx>

Reported-and-tested-by: Jiri Kosina <jkosina@xxxxxxx>

> > Reported-by: Aaron Hill <aa1ronham@xxxxxxxxx>
> > Reported-by: Lukas Redlinger <rel+kernel@xxxxxxxxxx>
> > Reported-by: Oleksii Shevchuk <alxchk@xxxxxxxxx>
> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> Reviewed-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx>

Thanks,

-- 
Jiri Kosina
SUSE Labs




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux