On Tue, 1 Oct 2019, Toke Høiland-Jørgensen wrote:
> > - spin_unlock_bh(&fq->lock);
> > + spin_unlock(&fq->lock);
> > drv_wake_tx_queue(local, txqi);
> > - spin_lock_bh(&fq->lock);
> > + spin_lock(&fq->lock);
>
> Okay, so this will mean that the drv_wake_tx_queue() entry point will be
> called with bhs disabled. But there are lots of uses of
> spin_{,un}lock_bh() in tx.c:
I am fine with whatever fix for this you guys settle on :) Just for the
record, I proposed this back then:
http://lore.kernel.org/r/nycvar.YFH.7.76.1904151300160.9803@xxxxxxxxxxxxx
maybe it could be resurected, as I believe it'd fix this one as well?
But again, I have absolutely no preference either way, only that it'd be
nice to have this fixed :)
Thanks!
--
Jiri Kosina
SUSE Labs
