Hi, On 18/10/2017 02:03, greearb@xxxxxxxxxxxxxxx wrote: > From: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > This bug appears to have been added between 4.0 (which works for us), > and 4.4, which does not work. > > I think this is because the tx-offchannel logic gets in a loop when > ath10k_mac_tx_frm_has_freq(ar) is false, so pkt is never actually > sent to the firmware for transmit. > > This patch fixes the problem on 4.9 for me, and now HS20 clients > can work again with my firmware. > > Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> I have been struggling to send offchannels mgmt frames since a while, as I was always getting: [18099.253732] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e3780 [18102.293686] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e3780 [18105.333653] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e3780 [18108.373712] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e3780 [18111.413687] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e36c0 [18114.453726] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e3f00 [18117.493773] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e36c0 [18120.533631] ath10k_pci 0000:01:00.0: timed out waiting for offchannel skb cf0e3f00 After digging through the ath10k patchwork I have found this patch which touches exactly the code I was trying to debug. After applying this set of changes, I can confirm that sending offchannel frames works again like a charm. I have tested only one fw though: ver 10.4-3.5.3-00057. It's a bummer that this trivial but critical patch is not yet merged upstream :-( Tested-by: Antonio Quartulli <antonio.quartulli@xxxxxxxxx> -- Antonio Quartulli Kaiwoo.ai
