Felix Fietkau <nbd@xxxxxxxx> writes: > On 2019-09-27 11:07, Toke Høiland-Jørgensen wrote: >> Felix Fietkau <nbd@xxxxxxxx> writes: >> >>> On 2019-09-27 10:37, Toke Høiland-Jørgensen wrote: >>>> Felix Fietkau <nbd@xxxxxxxx> writes: >>>> >>>>> On 2019-09-27 09:45, Toke Høiland-Jørgensen wrote: >>>>>> Felix Fietkau <nbd@xxxxxxxx> writes: >>>>>> >>>>>>> Estimate by calculating duration for EWMA packet size + estimated A-MPDU >>>>>>> length on tx status events >>>>>> >>>>>> Would it make sense to move some of this code into mac80211? If we're >>>>>> going to do airtime estimation for queue limiting it may make sense to >>>>>> use this instead of the simplistic estimate I used in my RFC patch? >>>>> Sure. I mainly put it in the driver because I wanted to get it working, >>>>> tested and merged first without having to wait for a mac80211-next -> >>>>> wireless-drivers-next merge. >>>> >>>> Right, OK. So that means another patch set on top of this to move it >>>> afterwards? Don't suppose you can be convinced to take care of that as >>>> well? :) >>> I could, but I don't know when I will have time for it, since my plate >>> is pretty full at the moment. >> >> Heh, I was afraid you'd say that. That makes two of us; guess we'll see >> who gets around to it first, then :) >> >> Is there anything in your new airtime.c that is mt76-specific apart from >> the struct mt76_dev and struct mt76_rx_status parameters? > No, I made it as generic as possible to make it easy to move to > mac80211. mt76_rx_status mirrors ieee80211_rx_status very closely, and > going from mt76_dev to ieee80211_hw is easy as well. Awesome, thanks! -Toke
