On 2019-09-21 19:38, Kalle Valo wrote:
What's wrong with ath10k_sdio_hif_diag_read()? AFAICS this whole
function duplicates just what it does.
ath10k_sdio_hif_diag_read's buffer size is limit,
and the dump memory/register's buffer size is larger than the diag
window's limit,
if use it directly will trigger crash like this for every time.
[ 149.947624] ath10k_sdio mmc1:0001:1: ath10k_sdio_hif_diag_read
buf_len :4
[ 149.954741] ath10k_sdio mmc1:0001:1: ath10k_sdio_hif_diag_read
buf_len :240
[ 151.005143] Unable to handle kernel paging request at virtual address
ffffffc0080ab980
[ 151.013077] Mem abort info:
[ 151.015866] ESR = 0x96000045
[ 151.018918] Exception class = DABT (current EL), IL = 32 bits
[ 151.024830] SET = 0, FnV = 0
[ 151.027880] EA = 0, S1PTW = 0
[ 151.031016] Data abort info:
[ 151.033892] ISV = 0, ISS = 0x00000045
[ 151.037723] CM = 0, WnR = 1
[ 151.040691] swapper pgtable: 4k pages, 39-bit VAs, pgdp =
0000000073b23692
[ 151.047560] [ffffffc0080ab980] pgd=0000000000000000,
pud=0000000000000000
[ 151.054354] Internal error: Oops: 96000045 [#1] PREEMPT SMP
[ 151.059925] Modules linked in: ath10k_sdio ath10k_core rfcomm uinput
cros_ec_rpmsg mtk_cam_isp ath mac80211 mtk_fd hci_uart btqca bluetooth
mtk_scp mtk_rpmsg rpmsg_core ecdh_generic mtk_scp_ipi bridge stp llc
nf_nat_tftp nf_conntrack_tftp nf_nat_ftp nf_conntrack_ftp esp6 ah6
xfrm6_mode_tunnel xfrm6_mode_transport xfrm4_mode_tunnel
xfrm4_mode_transport ip6t_REJECT ip6t_ipv6header ipt_MASQUERADE fuse
cfg80211 iio_trig_sysfs cros_ec_sensors_sync cros_ec_sensors
cros_ec_sensors_ring industrialio_triggered_buffer kfifo_buf
cros_ec_sensors_core lzo_rle lzo_compress zram asix usbnet mii joydev
[last unloaded: ath10k_core]
[ 151.114537] Process swapper/0 (pid: 0, stack limit =
0x00000000e30dc665)
[ 151.121238] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.72 #11
[ 151.127327] Hardware name: MediaTek kukui rev1 board (DT)
[ 151.132724] pstate: 20000085 (nzCv daIf -PAN -UAO)
[ 151.137525] pc : __memcpy+0x110/0x180
[ 151.141193] lr : swiotlb_tbl_unmap_single+0x84/0x150
[ 151.146151] sp : ffffff8008003c60
[ 151.149462] x29: ffffff8008003c90 x28: ffffffa2a9611f38
[ 151.154774] x27: ffffffa2a92cc018 x26: 0000000000000000
[ 151.160087] x25: ffffffa2a90b8000 x24: 0000000000000001
[ 151.165399] x23: ffffffa2a975e000 x22: 0000000000001400
[ 151.170710] x21: 0000000000000000 x20: 00000000fc7ff000
[ 151.176021] x19: 00000000000000f0 x18: 0000000000000020
[ 151.181332] x17: 0000000000000000 x16: 0000000000000000
[ 151.186643] x15: 00000000ffffffff x14: 0000000000000000
[ 151.191955] x13: 0000000000000000 x12: 0000000000000000
[ 151.197266] x11: 0000000000000000 x10: 0000000000000000
[ 151.202578] x9 : 0000000000000000 x8 : 0000000000000000
[ 151.207890] x7 : 0000000000000000 x6 : ffffffc0080ab980
[ 151.213202] x5 : ffffff8016ffbdc8 x4 : 0000000000000000
[ 151.218514] x3 : 0000000000000002 x2 : 0000000000000070
[ 151.223825] x1 : fffffff37c7ff040 x0 : ffffffc0080ab980
[ 151.229138] Call trace:
[ 151.231585] __memcpy+0x110/0x180
[ 151.234899] unmap_single+0x6c/0x84
[ 151.238386] swiotlb_unmap_sg_attrs+0x54/0x80
[ 151.242744] __swiotlb_unmap_sg_attrs+0xa0/0xb8
[ 151.247277] msdc_unprepare_data+0x6c/0x84
[ 151.251372] msdc_request_done+0x58/0x84
[ 151.255292] msdc_data_xfer_done+0x1a0/0x1c8
[ 151.259559] msdc_irq+0x12c/0x17c
[ 151.262876] __handle_irq_event_percpu+0xe4/0x250
[ 151.267578] handle_irq_event_percpu+0x28/0x68
[ 151.272018] handle_irq_event+0x48/0x78
[ 151.275853] handle_fasteoi_irq+0xd0/0x1a0
[ 151.279948] __handle_domain_irq+0x84/0xc4
[ 151.284042] gic_handle_irq+0x124/0x1a4
[ 151.287875] el1_irq+0xb0/0x128
[ 151.291016] cpuidle_enter_state+0x298/0x328
[ 151.295282] cpuidle_enter+0x30/0x40
[ 151.298856] do_idle+0x190/0x270
[ 151.302081] cpu_startup_entry+0x24/0x28
[ 151.306005] rest_init+0xd4/0xe0
[ 151.309233] start_kernel+0x30c/0x38c
[ 151.312896] Code: a8c12027 a8c12829 a8c1302b a8c1382d (a88120c7)
[ 151.318987] ---[ end trace 4d779fa7753769c5 ]---
[ 151.342768] Kernel panic - not syncing: Fatal exception in interrupt
[ 151.349134] SMP: stopping secondary CPUs
[ 151.353074] Kernel Offset: 0x22a0400000 from 0xffffff8008000000
[ 151.358991] CPU features: 0x0,2188200c
[ 151.362735] Memory Limit: none
