Wen Gong <wgong@xxxxxxxxxxxxxx> writes: > Tx complete message from firmware cost bus bandwidth of sdio, and bus > bandwidth is the bollteneck of throughput, it will effect the bandwidth > occupancy of data packet of TX and RX. TBH I'm not enthuastic about this, this feels an ugly hack. And it adds yet another module parameter which I detest. > This patch disable TX complete indication from firmware for htt data > packet, it results in significant performance improvement on TX path. So how much does this feature improve through exactly? Do you have any numbers? > The downside of this patch is ath10k will not know the TX status of > the data packet for poor signal situation. Although upper network stack > or application layer have retry mechanism, the retry will be later than > ath10k get the TX fail status if not disable TX complete. I don't understand this description. What's the difference in practise from user's point of view? But I think this patch should dropped from the patchset and revisited after rest of the patches are applied. -- Kalle Valo
