On Tue, 2019-09-17 at 14:36 +0800, Yibo Zhao wrote: > > Do you mean it should be something like: > > Co-developed-by: Toke Høiland-Jørgensen <toke@xxxxxxx> > Signed-off-by: Yibo Zhao <yiboz@xxxxxxxxxxxxxx> > Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxx> Yes, I think you mean the right thing. For the record, it seems to me it should be From: A <...> [...] Co-developed-by: B <...> Signed-off-by: B <...> Signed-off-by: A <...> or so. IOW, I think having the same "From:" (which gets preserved in git as "Author") and "Co-developed-by" makes no sense? Your "From" line was implied, but I suppose you did mean that From would be yourself (as it was in the patch) and then the above seems right. Or you can add a "From: Toke ..." to your patch message and leave the "Co-developed-by: yourself" I suppose, the difference is in how git will record it. johannes