From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> RTL8822B/RTL8822C series devices are capable of entering deep PS mode. In contrast to Leisure Power Save (LPS) which turns off RF components periodically between beacons, deep PS mode turns off more hardware circuits. But device should enter LPS before enter deep PS mode, otherwise the state of the firmware is undefined. Under deep PS mode, driver can not read/write registers, and also the TX path is reuiqred to be idle. To make sure it, driver should acquired rtwdev->mutex lock, and then leave deep PS mode before operating on the hardware, otherwise the behavior of the device is unexpected and undefined. To add deep PS mode, some modifications for the driver are needed. For PCI part, drivers need to keep tracking on the SKBs delivered to the device and see if there will have any activity on the TX path. For the others, driver should make sure to acquire lock and leave deep PS mode. Also remove a misleading module parameter named "rtw_fw_support_lps". It is not representing property of the firmware, but to let driver decide if it wants to use LPS mode. But IEEE80211_CONF_PS can handle it, by setting power save [on/off] through user space. So just remove it, and listen to IEEE80211_CONF_CHANGE_PS. Yan-Hsuan Chuang (15): rtw88: remove redundant flag check helper function rtw88: configure firmware after HCI started rtw88: pci: reset H2C queue indexes in a single write rtw88: pci: extract skbs free routine for trx rings rtw88: pci: release tx skbs DMAed when stop rtw88: not to enter or leave PS under IRQ rtw88: not to control LPS by each vif rtw88: remove unused lps state check helper rtw88: LPS enter/leave should be protected by lock rtw88: leave PS state for dynamic mechanism rtw88: add deep power save support rtw88: not to enter LPS by coex strategy rtw88: select deep PS mode when module is inserted rtw88: add deep PS PG mode for 8822c rtw88: remove misleading module parameter rtw_fw_support_lps drivers/net/wireless/realtek/rtw88/coex.c | 14 +-- drivers/net/wireless/realtek/rtw88/debug.h | 1 + drivers/net/wireless/realtek/rtw88/fw.c | 77 ++++++++++++ drivers/net/wireless/realtek/rtw88/fw.h | 29 +++++ drivers/net/wireless/realtek/rtw88/hci.h | 6 + drivers/net/wireless/realtek/rtw88/mac.c | 5 +- drivers/net/wireless/realtek/rtw88/mac80211.c | 43 +++++-- drivers/net/wireless/realtek/rtw88/main.c | 88 ++++++++------ drivers/net/wireless/realtek/rtw88/main.h | 32 +++-- drivers/net/wireless/realtek/rtw88/pci.c | 125 +++++++++++++++++--- drivers/net/wireless/realtek/rtw88/phy.c | 2 +- drivers/net/wireless/realtek/rtw88/ps.c | 162 +++++++++++++++++--------- drivers/net/wireless/realtek/rtw88/ps.h | 14 ++- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 1 + drivers/net/wireless/realtek/rtw88/rtw8822c.c | 1 + drivers/net/wireless/realtek/rtw88/rx.c | 2 - drivers/net/wireless/realtek/rtw88/sec.c | 21 ++++ drivers/net/wireless/realtek/rtw88/sec.h | 1 + drivers/net/wireless/realtek/rtw88/tx.c | 2 - 19 files changed, 471 insertions(+), 155 deletions(-) -- 2.7.4
