Search Linux Wireless

Re: [PATCH] rtw88: 8822c: fix boolreturn.cocci warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



kbuild test robot <lkp@xxxxxxxxx> writes:

> From: kbuild test robot <lkp@xxxxxxxxx>
>
> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2606:9-10: WARNING: return of 0/1 in function 'rtw8822c_dpk_coef_iq_check' with return type bool
>
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
>
> Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
> CC: Tzu-En Huang <tehuang@xxxxxxxxxxx>
> Signed-off-by: kbuild test robot <lkp@xxxxxxxxx>
> ---
>
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
> head:   f9e568754562e0f506e12aa899c378b4155080e9
> commit: 5227c2ee453d2f778192d8bb0f1a6072892aaa8e [23/32] rtw88: 8822c: add SW DPK support
>
>  rtw8822c.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> @@ -2603,9 +2603,9 @@ static bool rtw8822c_dpk_coef_iq_check(s
>  {
>  	if (coef_i == 0x1000 || coef_i == 0x0fff ||
>  	    coef_q == 0x1000 || coef_q == 0x0fff)
> -		return 1;
> +		return true;
>  	else
> -		return 0;
> +		return false;

Can someone submit this to linux-wireless so that patchwork can see it,
please?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux