Rakesh Pillai <pillair@xxxxxxxxxxxxxx> wrote: > The tlv targets such as WCN3990 send more data in the chan info event, which is > not sent by the non tlv targets. There is a minimum size check in the wmi event > for non-tlv targets and hence we cannot update the common channel info > structure as it was done in commit 13104929d2ec ("ath10k: fill the channel > survey results for WCN3990 correctly"). This broke channel survey results on > 10.x firmware versions. > > If the common channel info structure is updated, the size check for chan info > event for non-tlv targets will fail and return -EPROTO and we see the below > error messages > > ath10k_pci 0000:01:00.0: failed to parse chan info event: -71 > > Add tlv specific channel info structure and restore the original size of the > common channel info structure to mitigate this issue. > > Tested HW: WCN3990 > QCA9887 > Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 > 10.2.4-1.0-00037 > > Fixes: 13104929d2ec ("ath10k: fill the channel survey results for WCN3990 correctly") > Cc: stable@xxxxxxxxxxxxxxx # 5.0 > Signed-off-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 6be6c04bcc2e ath10k: fix channel info parsing for non tlv target -- https://patchwork.kernel.org/patch/10844513/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches