greearb@xxxxxxxxxxxxxxx wrote: > My wave-1 firmware often crashes when I am bringing down > AP vdevs, and sometimes at least some machines lockup hard > after spewing IOMMU errors. > > I don't see the same issue in STA mode, so I suspect beacons > are the issue. > > Moving the beacon buf deletion to later in the vdev teardown > logic appears to help this problem. Firmware still crashes > often, but several iterations did not show IOMMU errors and > machine didn't hang. I'm not really fond of fixing issues just by luck but after a quick look at the code I can't see any harm in this change either. So I guess it's ok. But can you provide the exact hardware and firmware you used for testing, I'll add it to the commit log. I want to document that in every commit: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines Please also CC ath10k list when submitting patches. -- https://patchwork.kernel.org/patch/10831867/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
