On Tue, 3 Sep 2019 at 20:59, Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> wrote: > On 9/3/2019 6:29 AM, Rafał Miłecki wrote: > > From: Rafał Miłecki <rafal@xxxxxxxxxx> > > > > This moves "ops" pointer from "struct brcmf_cfg80211_info" to the > > "struct brcmf_pub". This movement makes it possible to allocate wiphy > > without attaching cfg80211 (brcmf_cfg80211_attach()). It's required for > > later separation of wiphy allocation and driver initialization. > > > > While at it fix also an unlikely memory leak in the brcmf_attach(). > > Always good ;-) > > I recall there is some fiddling with the callback ops in cfg80211.c. Is > that broken by this reorg. Need to look into that. I don't see how this patch could break that. It still calls brcmf_cfg80211_get_ops() and passes settings as an argument. -- Rafał