Search Linux Wireless

Re: [PATCH] cfg80211: Add new helper function for channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-08-30 04:03, Arend Van Spriel wrote:
On 8/30/2019 12:41 PM, Johannes Berg wrote:
On Fri, 2019-08-30 at 12:40 +0200, Arend Van Spriel wrote:

+EXPORT_SYMBOL(ieee80211_channel_op_class_to_frequency);

The function ieee80211_operating_class_to_band() uses ranges within
switch statement, eg.:

          case 128 ... 130:
                  *band = NL80211_BAND_5GHZ;
                  return true;

No that you remind me - how is this new function not just a composition
of the existing ones?

i.e. just convert the op_class to band first, and then (band, channel)
to freq?

yup. that would have my preference actually.

Sigh. I had the same guidance in pre-review:

we already have ieee80211_operating_class_to_band() and ieee80211_channel_to_frequency() so all this function should be is

return ieee80211_channel_to_frequency(chan, ieee80211_operating_class_to_band(op_class))

but then again if anybody needs this functionality they can simply call those same functions



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux