Re: [PATCH] brcmfmac: replace strncpy() by strscpy()

Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> · Fri, 23 Aug 2019 10:18:13 +0200

On 8/23/2019 9:47 AM, Xulin Sun wrote:
The strncpy() may truncate the copied string,
replace it by the safer strscpy().

To avoid below compile warning with gcc 8.2:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:In function 'brcmf_vndr_ie':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4227:2:
warning: 'strncpy' output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation]
   strncpy(iebuf, add_del_cmd, VNDR_IE_CMD_LEN - 1);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Signed-off-by: Xulin Sun <xulin.sun@xxxxxxxxxxxxx>
---
  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)