On Sat, 2019-08-10 at 18:10 +0530, Tamizh chelvam wrote:
> On 2019-07-31 14:55, Johannes Berg wrote:
> > On Tue, 2019-06-18 at 10:57 +0530, Tamizh chelvam wrote:
> > > /**
> > > + * enum nl80211_tid_config - TID config state
> > > + * @NL80211_TID_CONFIG_DEFAULT: Default config for the TID
> > > + * @NL80211_TID_CONFIG_ENABLE: Enable config for the TID
> > > + * NL80211_TID_CONFIG_DISABLE: Disable config for the TID
> > > + */
> > > +enum nl80211_tid_config {
> > > + NL80211_TID_CONFIG_DEFAULT,
> > > + NL80211_TID_CONFIG_ENABLE,
> > > + NL80211_TID_CONFIG_DISABLE,
> > > +};
> >
> > Hmm. Looking at this in more detail in patch 3, I don't understand.
> >
> > How is DEFAULT different from "attribute not present", i.e. "no
> > changes"?
> >
> This DEFAULT is used to notify the driver to use default configuration
> value of driver/vif.
> This will be used when the attribute is not present.
Hm, but then why is it valid in the nl80211 attribute? That seems
confusing. Maybe there should rather be a validity bit somewhere in the
internal API, so the nl82011 API doesn't need to be concerned with this?
johannes
