On Mon, Aug 19, 2019 at 12:16:03PM +0200, Johannes Berg wrote: > On Thu, 2019-08-15 at 16:38 +0300, Jouni Malinen wrote: > > From: Gurumoorthi Gnanasambandhan <gguru@xxxxxxxxxxxxxx> > > > > This provides an alternative mechanism for AP VLAN support where a > > single netdev is used with VLAN tagged frames instead of separate > > netdevs for each VLAN without tagged frames from the WLAN driver. > > > > By setting NL80211_EXT_FEATURE_VLAN_OFFLOAD flag the driver indicates > > support for a single netdev with VLAN tagged frames. Separate > > VLAN-specific netdevs are added using vcongig similar to Ethernet. > > NL80211_CMD_NEW_KEY and NL80211_CMD_SET_STATION will optionally specify > > vlan_id using NL80211_ATTR_VLAN_ID. > > Without really looking at the specifics, it might be relatively simple > to support this in mac80211? Yes, that is something that I was thinking about when going through this.. I don't remember why exactly mac80211 ended up with its current design for per-AP_VLAN netdevs without tags, but it could indeed be quite convenient to have this alternative approach available. I guess both of them have some benefits, so this would likely be left with two different mechanisms left to maintain, but the needed implementation in mac80211 for this would seem to be pretty minimal (also without looking at the exact details..). -- Jouni Malinen PGP id EFC895FA
