Hi Dan On 8/7/19 4:03 AM, Dan Carpenter wrote: > External E-Mail > > > On Tue, Aug 06, 2019 at 07:32:08PM +0000, Adham.Abozaeid@xxxxxxxxxxxxx wrote: >> Hi Dan >> >> On 8/6/19 5:46 AM, Dan Carpenter wrote: >>> External E-Mail >>> >>> >>> On Thu, Jul 25, 2019 at 09:31:34PM +0000, Adham.Abozaeid@xxxxxxxxxxxxx wrote: >>>> From: Adham Abozaeid <adham.abozaeid@xxxxxxxxxxxxx> >>>> >>>> remove obtaining_ip from struct wilc_vif >>>> >>> How is this "unused"? It looks like it is used to me. >> The main usage of obtaining_ip was to track the inetadd_notifier status. >> After removing the notifier and ip address timeout timer in the first and second patch, >> the remaining usage became meaningless, and could be removed. > This is exactly the level of detail that I would like in a commit > description. Sure. Will do my best in the future to add more details in the commit description. Thanks, Adham
