> From: Arend Van Spriel [mailto:arend.vanspriel@xxxxxxxxxxxx] > > On 8/7/2019 10:48 AM, yhchuang@xxxxxxxxxxx wrote: > > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > > > Add WoW firmware to support entering Wake on WirelessLAN mode > > > > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > > --- > > > > v1 -> v2 > > * update WHENCE file for new added firmware > > > > WHENCE | 1 + > > rtw88/rtw8822c_wow_fw.bin | Bin 0 -> 138720 bytes > > 2 files changed, 1 insertion(+) > > create mode 100755 rtw88/rtw8822c_wow_fw.bin > > Just wondering: Is this a good approach? What firmware should distros > pick? Is there a trade-off affecting other wifi functionality when using > WoW firmware? > If distros want to use WOW, they should pick both. For Realtek devices such as RTL8822CE, it needs to "change/re-download" the wow firmware to suspend with WOW functionalities. When resume, switch back to normal firmware to run "normally". I think the reason is the firmware size restriction. For newer devices, maybe there is a larger space for firmware, and we don't need to swap the FW like this :) Yan-Hsuan