On 2019-08-06 19:31, Lorenzo Bianconi wrote: > Move mt76{15,03}_tx_tasklet in mt76 module since it is shared between > mt7615 and mt7603 drivers > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> I think it would be nice to get rid of the EXPORT_SYMBOL_GPL for mt76_tx_tasklet by moving the tasklet_init call to mt76_alloc_device(). That way, dev->mt76.tx_tasklet will be set to mt76_tx_tasklet by default, but automatically overwritten for drivers that have custom implementations (76x02 / usb). - Felix