Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > This reverts commit 437322ea2a36d112e20aa7282c869bf924b3a836. > > This above-mentioned "fix" does not actually do anything to prevent a > race condition. It simply papers over it so that the issue doesn't > appear. > > If this is a real problem, it should be explained better than the above > commit does, and an alternative, non-racy solution should be found. > > For further reason to revert this: there's no reason we can't try > resetting the card when it's *actually* stuck in host-sleep mode. So > instead, this is unnecessarily creating scenarios where we can't recover > Wifi (and in fact, I'm fielding reports of Chromebooks that can't > recover after the aforementioned commit). > > Note that this was proposed in 2017 and Ack'ed then, but due to my > marking as RFC, it never went anywhere: > > https://patchwork.kernel.org/patch/9657277/ > [RFC] Revert "mwifiex: fix system hang problem after resume" > > Cc: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> > Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > Acked-by: Amitkumar Karwar <amitkarwar@xxxxxxxxx> > Tested-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx> Patch applied to wireless-drivers-next.git, thanks. 654026df2635 Revert "mwifiex: fix system hang problem after resume" -- https://patchwork.kernel.org/patch/11077645/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
