Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > We're just trusting that these tables are of the right dimensions, when > we could do better by just using the struct directly. Let's expose the > struct txpwr_lmt_cfg_pair instead. > > The table changes were made by using some Vim macros, so that should > help prevent any translation mistakes along the way. > > Remaining work: get the 'void *data' out of the generic struct > rtw_table; all of these tables really deserve to be their own data > structure, with proper type fields. > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> To me this looks like a clear improvement and I'm inclined to apply it. Tony, what do you think? -- https://patchwork.kernel.org/patch/11042813/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches