On Wed, 2019-07-24 at 11:03 +0800, Roy Luo wrote: > Hi Ryder, > > Please follow the convention, some of your header files use //. > > C source: // SPDX-License-Identifier: <SPDX License Expression> > C header: /* SPDX-License-Identifier: <SPDX License Expression> */ > > Regards, > Cheng-Hao (Roy) Luo I also found that - copy paste mistake. And I will fold this one into 'fix many checkpatch.pl warnings' series then send v1. Ryder > On Tue, Jul 23, 2019 at 2:45 PM Ryder Lee <ryder.lee@xxxxxxxxxxxx> wrote: > > > > Add SPDX identifiers to all remaining files in mt76/ > > > > Signed-off-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx> > > ---