Re: [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values

[Kalle Valo <kvalo@xxxxxxxxxxxxxx>]

Ryder Lee <ryder.lee@xxxxxxxxxxxx> writes:

> Add initial values in mt7615_mcu_set_wmm() to cleanup setup flow.
>
> Signed-off-by: Ryder Lee <ryder.lee@xxxxxxxxxxxx>

[...]

> -#define WMM_AIFS_SET	BIT(0)
> -#define WMM_CW_MIN_SET	BIT(1)
> -#define WMM_CW_MAX_SET	BIT(2)
> -#define WMM_TXOP_SET	BIT(3)
> +#define WMM_PARAM_SET	GENMASK(3, 0)

I don't see how this is any better? IMHO you just hide what is the
meaning of each bit.

-- 
Kalle Valo