On 11.07.2019 11:05, Arend van Spriel wrote:
When brcmf_detach() from the bus layer upon rmmod we can no longer communicate. Hence we will set the bus state to DOWN and cleanup the event and protocol layer. The network interfaces need to be deleted before brcmf_cfg80211_detach() because the latter does the wiphy_unregister() which issues a warning if there are still network devices linked to the wiphy instance. Reviewed-by: Hante Meuleman <hante.meuleman@xxxxxxxxxxxx> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@xxxxxxxxxxxx> Reviewed-by: Franky Lin <franky.lin@xxxxxxxxxxxx> Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
This fixes a rmmod crash in brcmf_txfinalize() that I reported in the: brcmfmac: NULL pointer dereference during brcmf_detach() after firmware crash <b519e746-ddfd-421f-d897-7620d229e4b2@xxxxxxxxx> https://www.spinics.net/lists/linux-wireless/msg182913.html Tested-by: Rafał Miłecki <rafal@xxxxxxxxxx>
