On Wed, 2019-06-12 at 16:26 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. This driver was saving the debugfs file away to be > removed at a later time. However, the 80211 core would delete the whole > directory that the debugfs files are created in, after it asks the > driver to do the deletion, so just rely on the 80211 core to do all of > the cleanup for us, making us not need to keep a pointer to the dentries > around at all. > > This cleans up the structure of the driver data a bit and makes the code > a tiny bit smaller. > > Cc: Johannes Berg <johannes.berg@xxxxxxxxx> > Cc: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> > Cc: Luca Coelho <luciano.coelho@xxxxxxxxx> > Cc: Intel Linux Wireless <linuxwifi@xxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- Thanks, Greg! I applied this to our internal tree and it will reach the mainline following our normal upstreaming process. -- Cheers, Luca.