On 7/2/2019 11:50 AM, Markus Elfring wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Tue, 2 Jul 2019 11:31:07 +0200 A line break and a single string should be put into a sequence. Thus use the corresponding output functions. This issue was detected by using the Coccinelle software.
pot-ato, po-tato
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c index 73aff4e4039d..ec0e80296e43 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c @@ -225,10 +225,10 @@ static int brcmf_feat_fwcap_debugfs_read(struct seq_file *seq, void *data) } /* Usually there is a space at the end of capabilities string */ - seq_printf(seq, "%s", caps); + seq_puts(seq, caps); /* So make sure we don't print two line breaks */ if (tmp > caps && *(tmp - 1) != '\n') - seq_printf(seq, "\n"); + seq_putc(seq, '\n'); return 0; } -- 2.22.0
