On Mon, Jun 17, 2019 at 2:56 PM Chris Chiu <chiu@xxxxxxxxxxxx> wrote: > With this commit, the tx rate of each data and qos data packet will > be 39Mbps (MCS4) with the 0xF00000 as the tx rate mask. The 20th bit > to 23th bit means MCS4 to MCS7. It means that the firmware still picks > the lowest rate from the rate mask and explains why the tx rate of > data and qos data is always lowest 1Mbps because the default rate mask > passed is always 0xFFFFFFF ranges from the basic CCK rate, OFDM rate, > and MCS rate. However, with Realtek's driver, the tx rate observed from > wireshark under the same condition is almost 65Mbps or 72Mbps suggestion: add: , indicating that rtl8xxxu could still be further improved. Then remove this paragraph, I think we're in agreement of the approach here: > I believe the firmware of RTL8723BU may need fix. And I think we > can still bring in the dm_watchdog as rtlwifi to improve from the > driver side. Please leave precious comments for my commits and > suggest what I can do better. Or suggest if there's any better idea > to fix this. Thanks. > Signed-off-by: Chris Chiu <chiu@xxxxxxxxxxxx> Reviewed-by: Daniel Drake <drake@xxxxxxxxxxxx> > + * is supported and no iface_combinations are providec. typo: provided
