Hi Alastair, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc6 next-20190625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alastair-D-Silva/Hexdump-Enhancements/20190625-224046 config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=sh If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/gpu//drm/tinydrm/core/tinydrm-helpers.c: In function 'tinydrm_dbg_spi_print': >> drivers/gpu//drm/tinydrm/core/tinydrm-helpers.c:93:2: error: too many arguments to function 'hex_dump_to_buffer' hex_dump_to_buffer(buf, tr->len, 16, ^~~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/kobject.h:19, from include/linux/device.h:16, from include/linux/backlight.h:12, from drivers/gpu//drm/tinydrm/core/tinydrm-helpers.c:6: include/linux/printk.h:523:19: note: declared here static inline int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, ^~~~~~~~~~~~~~~~~~ -- sound/soc//sof/xtensa/core.c: In function 'xtensa_stack': >> sound/soc//sof/xtensa/core.c:125:3: error: too many arguments to function 'hex_dump_to_buffer' hex_dump_to_buffer(stack + i * 4, 16, 16, 4, ^~~~~~~~~~~~~~~~~~ In file included from include/linux/kernel.h:15:0, from include/linux/list.h:9, from include/linux/module.h:9, from sound/soc//sof/xtensa/core.c:11: include/linux/printk.h:523:19: note: declared here static inline int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, ^~~~~~~~~~~~~~~~~~ vim +/hex_dump_to_buffer +93 drivers/gpu//drm/tinydrm/core/tinydrm-helpers.c 9f69eb5c Noralf Trønnes 2017-01-22 85 9f69eb5c Noralf Trønnes 2017-01-22 86 static void 9f69eb5c Noralf Trønnes 2017-01-22 87 tinydrm_dbg_spi_print(struct spi_device *spi, struct spi_transfer *tr, 9f69eb5c Noralf Trønnes 2017-01-22 88 const void *buf, int idx, bool tx) 9f69eb5c Noralf Trønnes 2017-01-22 89 { 9f69eb5c Noralf Trønnes 2017-01-22 90 u32 speed_hz = tr->speed_hz ? tr->speed_hz : spi->max_speed_hz; 9f69eb5c Noralf Trønnes 2017-01-22 91 char linebuf[3 * 32]; 9f69eb5c Noralf Trønnes 2017-01-22 92 9f69eb5c Noralf Trønnes 2017-01-22 @93 hex_dump_to_buffer(buf, tr->len, 16, 9f69eb5c Noralf Trønnes 2017-01-22 94 DIV_ROUND_UP(tr->bits_per_word, 8), 9f69eb5c Noralf Trønnes 2017-01-22 95 linebuf, sizeof(linebuf), false); 9f69eb5c Noralf Trønnes 2017-01-22 96 9f69eb5c Noralf Trønnes 2017-01-22 97 printk(KERN_DEBUG 9f69eb5c Noralf Trønnes 2017-01-22 98 " tr(%i): speed=%u%s, bpw=%i, len=%u, %s_buf=[%s%s]\n", idx, 9f69eb5c Noralf Trønnes 2017-01-22 99 speed_hz > 1000000 ? speed_hz / 1000000 : speed_hz / 1000, 9f69eb5c Noralf Trønnes 2017-01-22 100 speed_hz > 1000000 ? "MHz" : "kHz", tr->bits_per_word, tr->len, 9f69eb5c Noralf Trønnes 2017-01-22 101 tx ? "tx" : "rx", linebuf, tr->len > 16 ? " ..." : ""); 9f69eb5c Noralf Trønnes 2017-01-22 102 } 9f69eb5c Noralf Trønnes 2017-01-22 103 :::::: The code at line 93 was first introduced by commit :::::: 9f69eb5c36a644571cca6b2f8dc5f6a7cba04a8b drm/tinydrm: Add helper functions :::::: TO: Noralf Trønnes <noralf@xxxxxxxxxxx> :::::: CC: Noralf Trønnes <noralf@xxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
