Hi On 2019-06-12, Johannes Berg wrote: > On Thu, 2019-06-06 at 20:41 +0200, Tom Psyborg wrote: > > > > Applying this patch instead of v1 broke WDS operation between two > > Litebeam AC Gen2 devices: > > I'm confused, and not even sure which version I applied now. > > Manikanta, can you please check this and which version I have and which > changes I might need? I've tested (and left it running/ monitored) for two days without any problems between QCA9984 (ZyXEL nbg6817/ ipq8065, WDS-AP, affected before 33d915d9e8ce811d8958915ccd18d71a66c7c495 "{nl,mac}80211: allow 4addr AP operation on crypto controlled devices" went in) and AR9340 (TP-Link TL-WDR3600/ AR9344, WDS-Client, not affected by this issue), both under current (~2 days old) OpenWrt master[1] (ipq806x/ ath79, respectively). This patch is working fine and fixes the previous problems with 4addr on ath10k (QCA9984). Thank you a lot for looking into this! Regards Stefan Lippers-Hollmann -- [1] Loading modules backported from Linux version v4.19.32-0-g3a2156c839c7 Backport generated by backports.git v4.19.32-1-0-g1c4f7569 with this version of the patch applied, instead of v1 as currently present in OpenWrt/ master HEAD.